Store creation M2: site creation Networking & Yosemite layer changes #8107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unit tests to avoid conflict with `SiteAction` usage in the app.
…iteRemote` unit tests.
…r handling and result type conversion.
Generated by 🚫 dangerJS |
Collaborator
You can test the changes from this Pull Request by:
|
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8106
Description
After domain selection and before IAP, we need to create a free site and then pass the site ID for purchasing the eCommerce plan via IAP. This PR includes the Networking & Yosemite layer changes for creating a site, with parameters following the
woocommerce.com/startflow on the web (the store configurations might change after the store becomes Atomic after IAP success). Sorry about the changes exceeding 500 diffs slightly 🙇🏻♀️ I thought it's easier to review both the remote and Yosemite store, especially for error handling and why we need to manually convert the site ID string from the Networking layer response toInt64in Yosemite.SiteActionwas previously used in Yosemite unit tests, and I renamed it toMockSiteActionto avoid naming conflict.Testing instructions
The new
SiteAction.createSiteisn't used in the app, just CI is sufficient. Integration with the store creation flow will be in a separate PR.RELEASE-NOTES.txtif necessary.